The Dink Network

Bug list/things I should fix

Moon Child

March 26th 2013, 11:54 AM
wizardg.gif
leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
So I really don't want there to be any bugs left in this game. But I know of at least two currently.

All the known bugs are fixed.

March 26th 2013, 06:48 PM
wizardb.gif
Kyle
Peasant Male Belgium
 
You deserve your own temporarily stickied thread for a new d-mod release
March 27th 2013, 07:41 AM
spike.gif
Nice dmod. Sweet map. Sadly, I've run into a few freeze bugs so far. One was when I descended the stairs from the meat restaurant; Dink stayed frozen, and the other was when I entered the slime cave; the screen wouldn't fade up and Dink stayed frozen. It might be the same bug as mentioned in this thread, although I didn't look at your scripts so I'm not sure.

Also, a less serious bug: When you tell the granny at the restaurant about the guy on the roof and she leaves, if you stay on the screen, she will wiggle her way back from behind the status bar after a while.
March 27th 2013, 08:03 AM
wizardg.gif
Leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
Thank you for letting me know
March 27th 2013, 01:32 PM
spike.gif
Okay, finished it. Man I rule. A worthy dmod for anyone who likes exploration, that's for sure, I'll have to write a review later.

A few more bugs:
*There's a flame behind the status bar on screen 158, on vision 0, that can instadeath you if you're close to the screen's edge
*Talking to red sitting guy at the ending froze me
*I couldn't enter the fireplace the way I was instructed (so I could only reach the ending the "bad" way)
March 27th 2013, 04:46 PM
wizardg.gif
Leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
*I couldn't enter the fireplace the way I was instructed (so I could only reach the ending the "bad" way)

There's no bug there. Also, there is no good ending. You can only enter the fireplace for the other ending. (I take it you listened to the pig and did what he asked you to do to get that ending?) There are two different ways to complete the game.

*Talking to red sitting guy at the ending froze me

Is he in the black room with the pig and the moon child? The one you go to after you beat the game?
March 27th 2013, 07:36 PM
dinkdead.gif
Good plan, Kyle

And yes, I have blatantly copied SabreTrout.
March 28th 2013, 07:45 AM
spike.gif
There's no bug there. Also, there is no good ending. You can only enter the fireplace for the other ending. (I take it you listened to the pig and did what he asked you to do to get that ending?) There are two different ways to complete the game.

Ah, I see. This is going to be pretty spoilerific:

The first time I just killed the pig. The second time I did what it told me to do, but when I couldn't enter the fireplace (or interact with it in any way), I thought that was a bug and ended the game. I see I should have tried going outside the castle.

Is he in the black room with the pig and the moon child? The one you go to after you beat the game?

Yeah. I think it's the achievement for the cannibal quest.
March 30th 2013, 09:21 PM
wizardg.gif
Leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
Anymore bugs to fix?
April 4th 2013, 07:38 AM
wizard.gif
purple
Peasant Female
 
there is one in the area after passing the bridge. the sign near it says "slime pit, dangerous....". whenever I try to enter, game freezes and there is just a black screen. then it says "Dink Smallwood failed! Error code - 805306369."
April 4th 2013, 09:39 AM
wizardg.gif
Leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
That area is fixed in the latest version. It's just a little cave with some slimes to fight. Nothing important.
April 14th 2013, 09:09 AM
anon.gif
shevek
Ghost
 
Great dmod!

I have a couple of bugs for you:

dungeon.c doesn't seem to work for me. After killing moon child and pig, I can enter, but the screen doesn't fade up again. Looking at the script, I have no idea why that is. It seems similar to Robj's problem in the race videos. Removing the fade_down works, though.

In dungeon.c, you also have the arguments for sp_x and sp_y reversed.

Looking at the code there, I also noticed that you use script_attach(1000), but not kill_this_task(). That means the script will remain in memory forever. It won't break anything right away, but it's a very bad idea. I checked for other places where this might happen
(grep -L kill_this_task `grep -l script_attach *`):
end1, end2, end3: not a problem, I suppose; there is no "rest of the game" anyway. But still not proper.
fire: at the start, so not good at all.
nuthead: not a good idea.
dungeon, pigboss: near the end, so less of a problem.

When the village is burning, the teleporter back to the village leaves you in a flame, which is hard (but not impossible) to get out of.

The master dude has a very eleborate script, but for me the only thing he did was say "*CASTING*". No actual spells were cast. Looking at the code, I don't know what the problem is, though. I would guess that the script gets interrupted (because then it won't continue), but I don't see what would interrupt it. I don't see anything happen, even when I'm leaving the guy alone.

There's a hardness bug when approaching the dragon's den from the side where you're not supposed to be able to enter it.

Finally, when the pig was telling his story, I was like "So? Who cares, I want to get laid, the lady tells me to kill you, so I do that." But then Dink suddenly starts moaning about her experiments. I felt I should have been given a choice whether to care or not. And if not, she can of course turn him down anyway.

Well, that's a whole list of issues, so just to emphasize the main message, I'll repeat it: Great dmod!
April 14th 2013, 10:56 AM
wizardg.gif
leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
Hmm. I thought I fixed the dungeon script. I'll look into that.

I wrote most of the scripts before I knew the importance of using kill_this_task(); So many are missing that command. I'll add those in, thanks.

I'm not sure what teleporter you mean. I believe there are only two you can use, one being the moon child's castle, and the other being the the place with the sun that tells you how many steps you've completed.

The master should cast spells. I'm not sure why he wouldn't. You can get something that will cancel out a spell 1/3rd of the time. Maybe I forgot a check somewhere? He must have been pretty easy when he's not casting spells. Lucky you .

Hmm, hardness bug. That's no good.

That's weird. I must have forgotten a bracket somewhere.

Thanks for pointing these out.
April 14th 2013, 11:37 AM
anon.gif
shevek
Ghost
 
I'm not sure what teleporter you mean.

The thing that looks like a teleporter.

the place with the sun that tells you how many steps you've completed.

Yes, that one.

He must have been pretty easy when he's not casting spells.

Easy, yes, but he still took really long; he just needed lots of hits, even though I was level 8, I had put almost all my level points in strength (and I had a zord, of course). But he didn't do any damage to me at all.

However, I don't understand why. The console doesn't complain, and the script doesn't look wrong. But I'll check again to see what the problem could be.
April 14th 2013, 11:57 AM
wizardg.gif
leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
I think when I tested him I was like level 14,: had the armor, the zord, and the resist potion; and had the stat boost from the avoca and the vegetable caper. At that time he was still difficult. He was however casting spells. (Also had the speed boots from the empty weapon shop, but those are so easy to get I expect everyone grabbed them.)
April 14th 2013, 12:27 PM
wizardg.gif
leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
Finally, when the pig was telling his story, I was like "So? Who cares, I want to get laid, the lady tells me to kill you, so I do that." But then Dink suddenly starts moaning about her experiments. I felt I should have been given a choice whether to care or not. And if not, she can of course turn him down anyway.

Hmmm. I checked the pig's script and I don't see where that issue would occur. Although if it did happen to you there must be something wrong with it.

Also, I did seem to forget(actually just put in the wrong place) a bracket in the master's script. So that should be fixed now.

I added in all the kill_this_task(); 's where they belonged.

The warpout spot for the teleporter should be good now too.

I think I found the hardness bug. I put an invisible hard sprite to cover the very tiny hardness hole there. So that should be fixed.
April 14th 2013, 01:08 PM
anon.gif
shevek
Ghost
 
I'll check again to see what the problem could be.

One thing that probably shouldn't be a problem, but isn't right either:

int &dam = sp_touch_damage(&current_sprite, -1);


I'm not sure what this function returns (I think 0), but the result is in any case that the touch damage is set to the value -1, not that it returns the value.

This probably isn't a problem, unless Dink touches the master before the first power boost spell (at which point the touch damage is set to a "normal" value). If Dink touches the master while touch damage is -1, I think the script gets aborted (but I'm not sure; there's no touch() procedure, so the script may also keep running.)

But I've also found the real problem, which is indeed a bracket. You're not closing the bracket for the resist-check, which means nothing happens if Dink is not resistant. Instead, you have an extra bracket for the if (&mana >= 3) check, which means that nothing more will happen if mana < 3.
April 14th 2013, 01:13 PM
anon.gif
shevek
Ghost
 
Hmmm. I checked the pig's script and I don't see where that issue would occur. Although if it did happen to you there must be something wrong with it.

No, you misunderstood me. The scripts work fine, I just had a problem imagining Dink's thoughts.

In general, and certainly in this adventure, Dink doesn't care much about evil; he's very selfish. So if he could have sex with an evil person, let's do it. However, all of a sudden he's like "you're evil, now I have to kill you". That didn't feel natural to me.
April 14th 2013, 01:33 PM
wizardg.gif
leprochaun
Peasant Male Japan xbox steam bloop
Responsible for making things not look like ass 
I just had a problem imagining Dink's thoughts.

Oh right yes. I'll do something about that. It felt pretty forced to me too, so I'll change that ending around a little.