Reply to Re: Bug list/things I should fix
If you don't have an account, just leave the password field blank.
April 14th 2013, 09:09 AM
shevek
Great dmod!
I have a couple of bugs for you:
dungeon.c doesn't seem to work for me. After killing moon child and pig, I can enter, but the screen doesn't fade up again. Looking at the script, I have no idea why that is. It seems similar to Robj's problem in the race videos. Removing the fade_down works, though.
In dungeon.c, you also have the arguments for sp_x and sp_y reversed.
Looking at the code there, I also noticed that you use script_attach(1000), but not kill_this_task(). That means the script will remain in memory forever. It won't break anything right away, but it's a very bad idea. I checked for other places where this might happen
(grep -L kill_this_task `grep -l script_attach *`):
end1, end2, end3: not a problem, I suppose; there is no "rest of the game" anyway. But still not proper.
fire: at the start, so not good at all.
nuthead: not a good idea.
dungeon, pigboss: near the end, so less of a problem.
When the village is burning, the teleporter back to the village leaves you in a flame, which is hard (but not impossible) to get out of.
The master dude has a very eleborate script, but for me the only thing he did was say "*CASTING*". No actual spells were cast. Looking at the code, I don't know what the problem is, though. I would guess that the script gets interrupted (because then it won't continue), but I don't see what would interrupt it. I don't see anything happen, even when I'm leaving the guy alone.
There's a hardness bug when approaching the dragon's den from the side where you're not supposed to be able to enter it.
Finally, when the pig was telling his story, I was like "So? Who cares, I want to get laid, the lady tells me to kill you, so I do that." But then Dink suddenly starts moaning about her experiments. I felt I should have been given a choice whether to care or not. And if not, she can of course turn him down anyway.
Well, that's a whole list of issues, so just to emphasize the main message, I'll repeat it: Great dmod!
I have a couple of bugs for you:
dungeon.c doesn't seem to work for me. After killing moon child and pig, I can enter, but the screen doesn't fade up again. Looking at the script, I have no idea why that is. It seems similar to Robj's problem in the race videos. Removing the fade_down works, though.
In dungeon.c, you also have the arguments for sp_x and sp_y reversed.
Looking at the code there, I also noticed that you use script_attach(1000), but not kill_this_task(). That means the script will remain in memory forever. It won't break anything right away, but it's a very bad idea. I checked for other places where this might happen
(grep -L kill_this_task `grep -l script_attach *`):
end1, end2, end3: not a problem, I suppose; there is no "rest of the game" anyway. But still not proper.
fire: at the start, so not good at all.
nuthead: not a good idea.
dungeon, pigboss: near the end, so less of a problem.
When the village is burning, the teleporter back to the village leaves you in a flame, which is hard (but not impossible) to get out of.
The master dude has a very eleborate script, but for me the only thing he did was say "*CASTING*". No actual spells were cast. Looking at the code, I don't know what the problem is, though. I would guess that the script gets interrupted (because then it won't continue), but I don't see what would interrupt it. I don't see anything happen, even when I'm leaving the guy alone.
There's a hardness bug when approaching the dragon's den from the side where you're not supposed to be able to enter it.
Finally, when the pig was telling his story, I was like "So? Who cares, I want to get laid, the lady tells me to kill you, so I do that." But then Dink suddenly starts moaning about her experiments. I felt I should have been given a choice whether to care or not. And if not, she can of course turn him down anyway.
Well, that's a whole list of issues, so just to emphasize the main message, I'll repeat it: Great dmod!
