The Dink Network

Reply to Re: Gamestopping bug near the beginning

If you don't have an account, just leave the password field blank.
Username:
Password:
Subject:
Antispam: Enter Dink Smallwood's last name (surname) below.
Formatting: :) :( ;( :P ;) :D >( : :s :O evil cat blood
Bold font Italic font hyperlink Code tags
Message:
 
 
December 22nd 2015, 11:14 PM
dinkdead.gif
millimeter
Peasant He/Him Canada
Millimeter is Wee-Lamm, Recording Artist. :-) 
Seeing as this bug is still present in this file, as well as several others in both this DMod and others, I feel it is worth updating with my opinion for future Dinkers who will encounter this issue.

I believe, that the real issue is that the Choice function provides for 5 ifs, whereas there are only 4 thens with none being defined as the default or 'fall-through' path. By omitting the closing brace for the talk(void) function, the menu is only being dismissed visibly and not programmatically. This can be evidenced in V1.08HD by hitting escape for the menu which will have both the Map and Dink menu options, disabled because there is already a menu open.

While Scratcher's advice would indeed be a functional kludge by allowing the parser to see that there isn't anything following the "unfreeze(1);", I'm not convinced that this will allow the engine to handle housekeeping chores including purging the script from memory and invalidating any variables that may have been defined.

In my opinion, adding the closing brace is preferable to simply an empty line as it both provides a fall-through path for the 5th option, and informs the parser that any local variables can be removed from memory.

e.g.
...
unfreeze(1);
}

Mm