Reply to Re: New D-Mod: Cursed Blades Part 1: Charlie's Legacy
If you don't have an account, just leave the password field blank.
July 26th 2022, 05:50 PM
ghostknight
Oh my lord I'm blind, how did I not see that long?!
Well, someone made a comment in the line above with the clear intent that he wanted 'int' ... and then went on and defined 'long'
Hmm, perhaps, it would be a good idea to replace all shorts/ints/longs with int16_t/int32_t/int64_t to make sure everything is the intended size?...
I tried that but then the dmod did not recognize the freedink version. It said 1.08 (?), I think, and would not start. I did not investigate any further.
I was going to look for other 'long' variables that get assigned to 'int'.
There are some other issues that *might* be problematic, e.g., in line 2580:
The compiler issued a warning that source and destination overlap, so I changed that, too
I saw several statements, like
which should be changed to
I was thinking about uploading my build script which will compile the patched 109.6 version and install it in '/opt'. It *should* work on any debian based system. Let me know if there is interest for that or if you prefer to wait for the maintainer to release a new version.
Well, someone made a comment in the line above with the clear intent that he wanted 'int' ... and then went on and defined 'long'
Hmm, perhaps, it would be a good idea to replace all shorts/ints/longs with int16_t/int32_t/int64_t to make sure everything is the intended size?...
I tried that but then the dmod did not recognize the freedink version. It said 1.08 (?), I think, and would not start. I did not investigate any further.
I was going to look for other 'long' variables that get assigned to 'int'.
There are some other issues that *might* be problematic, e.g., in line 2580:
strcpy (s, h);
The compiler issued a warning that source and destination overlap, so I changed that, too
strcpy_nooverlap(s, h);
I saw several statements, like
intval = atol(parm);
which should be changed to
intval = atoi(parm);
I was thinking about uploading my build script which will compile the patched 109.6 version and install it in '/opt'. It *should* work on any debian based system. Let me know if there is interest for that or if you prefer to wait for the maintainer to release a new version.
