Reply to Re: Dink Smallwood HD: Native Linux (and Mac) Port – Collaboration & Testing
If you don't have an account, just leave the password field blank.
Thanks mateusbentes, I merged the new PR!
Also, I think you'll probably get more issue resistant PRs if you add something like to your tool prompting for future changes:
********* (add this to your prompt) ********
CRITICAL CONSTRAINT: This is a multi-platform codebase that builds for Windows, iOS, Android, HTML5/Emscripten, macOS, and Linux. Your changes MUST NOT break compilation or behavior on any existing platform. Follow these rules:
1. Never remove or modify code inside existing #ifdef guards (WINAPI, PLATFORM_IOS, PLATFORM_ANDROID, PLATFORM_HTML5, etc.) unless you fully understand what every platform path does.
2. When adding platform-specific code, use #if defined(PLATFORM_LINUX) || defined(PLATFORM_OSX) or similar narrow guards. Never use #else after a platform #ifdef as a catch-all -- it will hit every other platform including iOS, Android, and HTML5. Use #elif with explicit platform checks instead.
3. Before calling any function, verify it actually exists in the codebase or framework. Do not assume APIs exist -- search for their declarations first.
4. New functions and globals must be wrapped in platform guards so they only compile on platforms where they are needed.
5. Do not change the behavior of existing platforms as a side effect of adding new platform support. The goal is to ADD Linux/macOS support, not to refactor or "improve" working Windows/iOS/Android/HTML5 code.
6. All comments must be in English.
7. After making changes, mentally trace through compilation for each platform (Windows, iOS, Android, HTML5, Linux, macOS) and verify no platform hits an undefined function, missing symbol, or changed behavior.
Also, I think you'll probably get more issue resistant PRs if you add something like to your tool prompting for future changes:
********* (add this to your prompt) ********
CRITICAL CONSTRAINT: This is a multi-platform codebase that builds for Windows, iOS, Android, HTML5/Emscripten, macOS, and Linux. Your changes MUST NOT break compilation or behavior on any existing platform. Follow these rules:
1. Never remove or modify code inside existing #ifdef guards (WINAPI, PLATFORM_IOS, PLATFORM_ANDROID, PLATFORM_HTML5, etc.) unless you fully understand what every platform path does.
2. When adding platform-specific code, use #if defined(PLATFORM_LINUX) || defined(PLATFORM_OSX) or similar narrow guards. Never use #else after a platform #ifdef as a catch-all -- it will hit every other platform including iOS, Android, and HTML5. Use #elif with explicit platform checks instead.
3. Before calling any function, verify it actually exists in the codebase or framework. Do not assume APIs exist -- search for their declarations first.
4. New functions and globals must be wrapped in platform guards so they only compile on platforms where they are needed.
5. Do not change the behavior of existing platforms as a side effect of adding new platform support. The goal is to ADD Linux/macOS support, not to refactor or "improve" working Windows/iOS/Android/HTML5 code.
6. All comments must be in English.
7. After making changes, mentally trace through compilation for each platform (Windows, iOS, Android, HTML5, Linux, macOS) and verify no platform hits an undefined function, missing symbol, or changed behavior.
