The Dink Network

Reply to Re: freedinkedit is stuffed

If you don't have an account, just leave the password field blank.
Username:
Password:
Subject:
Antispam: Enter Dink Smallwood's last name (surname) below.
Formatting: :) :( ;( :P ;) :D >( : :s :O evil cat blood
Bold font Italic font hyperlink Code tags
Message:
 
 
June 4th 2016, 11:51 AM
peasantm.gif
shevek
Peasant They/Them Netherlands
Never be afraid to ask, but don't demand an answer 
My guess was right, it is a 64 bit problem. In src/freedinkedit.c, lines 595 and 596, the code uses sizeof(struct small_map), but that struct is not defined in a way to keep its size the same on all architectures.

Either that should be done by changing the "int"s into "int32_t"s in its definition (and adding "__attribute__((packed))"; it may work without it, but is appropriate for this situation), or (easier but worse for maintenance) it should be replaced by the number, as in save_map in src/dinkvar.c: 31280 (line 1044, which includes a comment warning about this exact problem; see what I mean by "worse for maintenance"?)