Reply to Re: Dink with Lua scripting, first public alpha
If you don't have an account, just leave the password field blank.
Hello!
I do recall our discussion of regression tests, and I also recall saying how I wouldn't know what to test for, because I am not particularly familiar with either DinkC or its fragile reliance on the Dink Engine. I've only done my best to not modify DinkC as best I could. Most importantly, I've left the parsing code ENTIRELY alone.
There has been some refactoring besides that, but mostly I've just moved the DinkC-specific code verbatim into a new function in a new file, and then called it directly from its old location. I did this with code I considered "shared" between DinkC and Lua just to not have the Lua part of the code rely on the DinkC part of the code.
If you know what to test for, you may feel free to write some of these tests, or at least tell me what things to look for so that I can write them myself. I've come to a point where I really don't want to deal with DinkC ever again... biggest part of why I wrote this Lua implementation, to be honest.
In the meantime, or if you're not interested in merging my code into yours because of worries over breaking DinkC, I will just keep a separate version of Dink going where DinkC backwards compatability isn't a concern, and then people will just have to use two different executables for DinkC mods and Lua mods. I obviously favor a merge, but it's not paramount.
I do recall our discussion of regression tests, and I also recall saying how I wouldn't know what to test for, because I am not particularly familiar with either DinkC or its fragile reliance on the Dink Engine. I've only done my best to not modify DinkC as best I could. Most importantly, I've left the parsing code ENTIRELY alone.
There has been some refactoring besides that, but mostly I've just moved the DinkC-specific code verbatim into a new function in a new file, and then called it directly from its old location. I did this with code I considered "shared" between DinkC and Lua just to not have the Lua part of the code rely on the DinkC part of the code.
If you know what to test for, you may feel free to write some of these tests, or at least tell me what things to look for so that I can write them myself. I've come to a point where I really don't want to deal with DinkC ever again... biggest part of why I wrote this Lua implementation, to be honest.
In the meantime, or if you're not interested in merging my code into yours because of worries over breaking DinkC, I will just keep a separate version of Dink going where DinkC backwards compatability isn't a concern, and then people will just have to use two different executables for DinkC mods and Lua mods. I obviously favor a merge, but it's not paramount.
